refactor: Remove deprecated Cache::$storePath
#9404
Merged
+16
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neznaika0
changed the title
Cache::$storePath
neznaika0
force-pushed
the
refactor/deprecated-filecache-property
branch
from
e6d6023 to
ad8e688
Compare
michalsn
reviewed
Jan 12, 2025
neznaika0
force-pushed
the
refactor/deprecated-filecache-property
branch
from
ad8e688 to
c83a505
Compare
michalsn
approved these changes
Jan 12, 2025
paulbalandan
approved these changes
Jan 13, 2025
neznaika0
force-pushed
the
refactor/deprecated-filecache-property
branch
from
c83a505 to
b7b2319
Compare
|
@neznaika0 pls rebase this again, first. after I merge this, you can rebase the others so we can minimise the rebases |
neznaika0
force-pushed
the
refactor/deprecated-filecache-property
branch
from
b7b2319 to
23f2559
Compare
|
Ready) |
|
Thank you @neznaika0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #4103 v4.0.5
$storePathhas been removed and the tests have been updated.Checklist: